[webkit-reviews] review granted: [Bug 196936] Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.selectionPathComponents') : [Attachment 367507] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 16 12:15:14 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 196936: Web Inspector: Uncaught Exception: TypeError: null is not an object
(evaluating
'this._contentViewContainer.currentContentView.selectionPathComponents')
https://bugs.webkit.org/show_bug.cgi?id=196936

Attachment 367507: Patch

https://bugs.webkit.org/attachment.cgi?id=367507&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 367507
  --> https://bugs.webkit.org/attachment.cgi?id=367507
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367507&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:198
> +	   if (this._contentViewContainer.CurrentContentViewDidChange)

Seems like a typo. Maybe for:

    this._contentViewContainer.currentContentView


More information about the webkit-reviews mailing list