[webkit-reviews] review denied: [Bug 196971] Show prompt for device orientation access if the client does not implement the corresponding API delegate : [Attachment 367550] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 196971: Show prompt for device orientation access if the client does not
implement the corresponding API delegate
https://bugs.webkit.org/show_bug.cgi?id=196971

Attachment 367550: Patch

https://bugs.webkit.org/attachment.cgi?id=367550&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367550
  --> https://bugs.webkit.org/attachment.cgi?id=367550
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367550&action=review

> Source/WebKit/UIProcess/Cocoa/WKOrientationAccessAlert.mm:40
> +    auto completionBlock = makeBlockPtr([completionHandler =
WTFMove(completionHandler)](bool shouldAllow) mutable {

Yep, we definitely need something like this.

> Source/WebKit/UIProcess/Cocoa/WKOrientationAccessAlert.mm:44
> +    UIAlertAction* cancelAction = [UIAlertAction actionWithTitle:@"Cancel"
style:UIAlertActionStyleCancel handler:[completionBlock](UIAlertAction *action)
{

Cancel and Allow also should be localized.