[webkit-reviews] review denied: [Bug 196971] Show prompt for device orientation access if the client does not implement the corresponding API delegate : [Attachment 367545] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 196971: Show prompt for device orientation access if the client does not
implement the corresponding API delegate
https://bugs.webkit.org/show_bug.cgi?id=196971

Attachment 367545: Patch

https://bugs.webkit.org/attachment.cgi?id=367545&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367545
  --> https://bugs.webkit.org/attachment.cgi?id=367545
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367545&action=review

> Source/WebKit/UIProcess/Cocoa/WKOrientationAccessAlert.h:31
> +#import <wtf/CompletionHandler.h>
> +#import <wtf/text/WTFString.h>

wtf/Forward.h should have everything necessary for this.

> Source/WebKit/UIProcess/Cocoa/WKOrientationAccessAlert.mm:35
> +    String alertText = makeString('"', host, "\" Would Like to Access Motion
and Orientation");

These strings need to be localized.

> Source/WebKit/UIProcess/Cocoa/WKOrientationAccessAlert.mm:40
> +    auto completionBlock = makeBlockPtr([completionHandler =
WTFMove(completionHandler)](bool shouldAllow) mutable {

I think this code would look better if we made a BlockPtr twice.