[webkit-reviews] review granted: [Bug 196963] [WTF] Generic memoryFootprint() implementation should use bmalloc on Linux : [Attachment 367519] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 196963: [WTF] Generic memoryFootprint() implementation should use bmalloc
on Linux
https://bugs.webkit.org/show_bug.cgi?id=196963

Attachment 367519: Patch

https://bugs.webkit.org/attachment.cgi?id=367519&action=review




--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 367519
  --> https://bugs.webkit.org/attachment.cgi?id=367519
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367519&action=review

r=me with nits

> Source/WTF/wtf/generic/MemoryFootprintGeneric.cpp:29
> +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && OS(LINUX)

Remove OS(LINUX) there's no reason for this to be OS specific.

> Source/WTF/wtf/generic/MemoryFootprintGeneric.cpp:37
> +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && OS(LINUX)

Same