[webkit-reviews] review denied: [Bug 196913] [GStreamer] Crash in AudioTrackPrivate with playbin3 enabled : [Attachment 367516] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied  review:
Bug 196913: [GStreamer] Crash in AudioTrackPrivate with playbin3 enabled
https://bugs.webkit.org/show_bug.cgi?id=196913

Attachment 367516: Patch

https://bugs.webkit.org/attachment.cgi?id=367516&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 367516
  --> https://bugs.webkit.org/attachment.cgi?id=367516
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367516&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:230
> +	   // USE_PLAYBIN3 is dangerous for us because its potential sneaky
effect
> +	   // is to register the playbin3 element under the playbin namespace.
We
> +	   // can't allow this, when we create playbin, we want playbin2, not
> +	   // playbin3.
> +	   unsetenv("USE_PLAYBIN3");

This will need a rethink. See https://bugs.webkit.org/show_bug.cgi?id=194370#c6
for why you can't do this.