[webkit-reviews] review granted: [Bug 196913] [GStreamer] Crash in AudioTrackPrivate with playbin3 enabled : [Attachment 367516] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 196913: [GStreamer] Crash in AudioTrackPrivate with playbin3 enabled
https://bugs.webkit.org/show_bug.cgi?id=196913

Attachment 367516: Patch

https://bugs.webkit.org/attachment.cgi?id=367516&action=review




--- Comment #8 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 367516
  --> https://bugs.webkit.org/attachment.cgi?id=367516
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367516&action=review

>From the GStreamer PoV, this is ok. I'll let Michael have the final word about
the env variables.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2372
> +    if ((!isMediaSource() && g_getenv("WEBKIT_GST_USE_PLAYBIN3")) ||
(url.protocolIs("mediastream")))

I think there are issues here with too many () .