[webkit-reviews] review granted: [Bug 196953] Web Inspector: DOM Nodes should not show $0 when selected in Console area : [Attachment 367491] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 196953: Web Inspector: DOM Nodes should not show $0 when selected in
Console area
https://bugs.webkit.org/show_bug.cgi?id=196953

Attachment 367491: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=367491&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 367491
  --> https://bugs.webkit.org/attachment.cgi?id=367491
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=367491&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:13
> +	   Make parameters explicit. Drop "selectable" which was always true.

It may be worth mentioning (or this comment can suffice) that there were other
creators of `WI.DOMTreeOutline`, but due to the fact that `WI.TreeOutline`'s
constructor has a default `selectable = true`, passing `undefined` as all three
arguments in those cases would fall back to the default `true`, so yes, it was
always `true`.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:66
> +	   this._domTreeOutline = new WI.DOMTreeOutline({omitRootDOMNode: true,
excludeRevealElementContextMenu: true, showLastSelected: true});

Nice!