[webkit-reviews] review granted: [Bug 196712] Modify how we do SetArgument when we inline varargs calls : [Attachment 367260] patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 196712: Modify how we do SetArgument when we inline varargs calls
https://bugs.webkit.org/show_bug.cgi?id=196712

Attachment 367260: patch

https://bugs.webkit.org/attachment.cgi?id=367260&action=review




--- Comment #13 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 367260
  --> https://bugs.webkit.org/attachment.cgi?id=367260
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367260&action=review

r=me

> Source/JavaScriptCore/ChangeLog:15
> +	   However, we used to always to emit SetArgumentDefinitely up to
"limit - 1" for

Awkward wording.  How about "However, we used to always emit ..."

> Source/JavaScriptCore/ChangeLog:16
> +	   all are arguments, even when some arguments aren't guaranteed to be
in a valid

Delete *are*?