[webkit-reviews] review granted: [Bug 196878] Bytecode cache should not encode the SourceProvider for UnlinkedFunctionExecutable's classSource : [Attachment 367346] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 14:30:40 PDT 2019


Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 196878: Bytecode cache should not encode the SourceProvider for
UnlinkedFunctionExecutable's classSource
https://bugs.webkit.org/show_bug.cgi?id=196878

Attachment 367346: Patch

https://bugs.webkit.org/attachment.cgi?id=367346&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 367346
  --> https://bugs.webkit.org/attachment.cgi?id=367346
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367346&action=review

>> Source/JavaScriptCore/ChangeLog:14
>> +	    multiple times in the cache.
> 
> How is this just not a general problem that affects all types that were
previously being de-duplicated during encoding?

I'm also curious.

--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 367346
  --> https://bugs.webkit.org/attachment.cgi?id=367346
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367346&action=review

r=me

>> Source/JavaScriptCore/ChangeLog:14
>> +	    multiple times in the cache.
> 
> How is this just not a general problem that affects all types that were
previously being de-duplicated during encoding?

can we open a bug so we can handle the general case?


More information about the webkit-reviews mailing list