[webkit-reviews] review denied: [Bug 196773] Add a DiagnosticLogging method taking an arbitrary dictionary of values. : [Attachment 367157] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 13:47:20 PDT 2019


Alex Christensen <achristensen at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 196773: Add a DiagnosticLogging method taking an arbitrary dictionary of
values.
https://bugs.webkit.org/show_bug.cgi?id=196773

Attachment 367157: Patch

https://bugs.webkit.org/attachment.cgi?id=367157&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367157
  --> https://bugs.webkit.org/attachment.cgi?id=367157
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367157&action=review

> Source/WebKit/UIProcess/API/C/WKPageDiagnosticLoggingClient.h:68
> +typedef struct WKPageDiagnosticLoggingClientV2 {

Let's not add to the C API for this.

> Source/WebKit/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:43
> +- (void)_webView:(WKWebView *)webView logDiagnosticMessage:(NSString
*)message description:(NSString *)description valueDictionary:(NSDictionary
*)valueDictionary;

Please add a test that this can be called in WKWebViewDiagnosticLogging.mm.


More information about the webkit-reviews mailing list