[webkit-reviews] review granted: [Bug 196898] TestRunner::notifyDone() should not be reentrant : [Attachment 367427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 11:03:50 PDT 2019

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 196898: TestRunner::notifyDone() should not be reentrant

Attachment 367427: Patch


--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 367427
  --> https://bugs.webkit.org/attachment.cgi?id=367427

View in context: https://bugs.webkit.org/attachment.cgi?id=367427&action=review

Guess it’s OK. Lets give it a try.

> Tools/DumpRenderTree/mac/TestRunnerMac.mm:301
> +	   fprintf(stderr, "TestRunner::notifyDone() called unexpectedly.");

So I guess it’s OK to do this since it won’t make tests fail? But it will fill
our test results with "stderr output"; if a reentrant call is *not* actually

More information about the webkit-reviews mailing list