[webkit-reviews] review granted: [Bug 196904] [CMake] WebCore derived sources should only be referenced inside WebCore : [Attachment 367419] Patch

[bugzilla-daemon at webkit.org]

Konstantin Tokarev <annulen at yandex.ru> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 196904: [CMake] WebCore derived sources should only be referenced inside
WebCore
https://bugs.webkit.org/show_bug.cgi?id=196904

Attachment 367419: Patch

https://bugs.webkit.org/attachment.cgi?id=367419&action=review




--- Comment #2 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 367419
  --> https://bugs.webkit.org/attachment.cgi?id=367419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367419&action=review

> Source/cmake/WebKitMacros.cmake:136
> +	   if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}")

Here we reference WebCore-specific variable from macro which is used in other
targets. Looks suspicious.

> Source/cmake/WebKitMacros.cmake:142
> +    source_group("DerivedSources" REGULAR_EXPRESSION
"${WebCore_DERIVED_SOURCES_DIR}")

Ditto.