[webkit-reviews] review granted: [Bug 196742] [CMake] JavaScriptCore derived sources should only be referenced inside JavaScriptCore : [Attachment 367355] Patch

[bugzilla-daemon at webkit.org]

Konstantin Tokarev <annulen at yandex.ru> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 196742: [CMake] JavaScriptCore derived sources should only be referenced
inside JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=196742

Attachment 367355: Patch

https://bugs.webkit.org/attachment.cgi?id=367355&action=review




--- Comment #2 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 367355
  --> https://bugs.webkit.org/attachment.cgi?id=367355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367355&action=review

> ChangeLog:9
> +	   to support moving the JavaScriptCore derived sources outside of a
shared directory.

Does it change anything besides variable name? Seems like both
JavaScriptCore_DERIVED_SOURCES_DIR and DERIVED_SOURCES_JAVASCRIPTCORE_DIR point
to the same path now