[webkit-reviews] review granted: [Bug 196884] r244079 logically broke shouldSpeculateInt52 : [Attachment 367362] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 196884: r244079 logically broke shouldSpeculateInt52
https://bugs.webkit.org/show_bug.cgi?id=196884

Attachment 367362: patch

https://bugs.webkit.org/attachment.cgi?id=367362&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 367362
  --> https://bugs.webkit.org/attachment.cgi?id=367362
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367362&action=review

r=me

> Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:738
> +	       if (type == SpecAnyIntAsDouble && enableInt52() &&
int52AwareSpeculationFromValue(m_currentNode->asJSValue()) ==
SpecNonInt32AsInt52)
> +		   type = SpecNonInt32AsInt52;

Why don't we say SpecInt32AsInt52 here for Int32 values in double?