[webkit-reviews] review granted: [Bug 196883] Enable modern compatibility mode by default in WKWebView on some devices : [Attachment 367357] Fix macOS builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 17:24:18 PDT 2019


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 196883: Enable modern compatibility mode by default in WKWebView on some
devices
https://bugs.webkit.org/show_bug.cgi?id=196883

Attachment 367357: Fix macOS builds

https://bugs.webkit.org/attachment.cgi?id=367357&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 367357
  --> https://bugs.webkit.org/attachment.cgi?id=367357
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=367357&action=review

> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:294
> +    static bool isAppleApplication =
applicationBundleStartsWith("com.apple."_s);
> +    return isAppleApplication;

This seems a bit broad as mentioned elsewhere.


More information about the webkit-reviews mailing list