[webkit-reviews] review granted: [Bug 196877] Provide a quirk to disable Pointer Events : [Attachment 367345] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 196877: Provide a quirk to disable Pointer Events
https://bugs.webkit.org/show_bug.cgi?id=196877

Attachment 367345: Patch

https://bugs.webkit.org/attachment.cgi?id=367345&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 367345
  --> https://bugs.webkit.org/attachment.cgi?id=367345
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367345&action=review

> Source/WebCore/ChangeLog:9
> +	   Add a quirk to disable Pointer Events and opt a website that has
compatibility issues when Pointer Events are enabled into this new quirk.

I think this is correct english, but it was hard to read.

> Source/WebCore/page/Quirks.cpp:239
> +    if (equalLettersIgnoringASCIICase(host, "mailchimp.com") ||
host.endsWithIgnoringASCIICase(".mailchimp.com"))

Annoying that there might be a site notmailchimp.com, or that we can't say
"[\.^]mailchimp\.com$" (not sure that's even a valid regexp)