[webkit-reviews] review granted: [Bug 196856] [ATK] Implement AtkComponentIface scroll_to methods : [Attachment 367320] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 196856: [ATK] Implement AtkComponentIface scroll_to methods
https://bugs.webkit.org/show_bug.cgi?id=196856

Attachment 367320: Patch

https://bugs.webkit.org/attachment.cgi?id=367320&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 367320
  --> https://bugs.webkit.org/attachment.cgi?id=367320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367320&action=review

> Tools/gtk/jhbuild.modules:284
> +  <meson id="atk" mesonargs="-Dintrospection=no">

meson.build:1:0: ERROR:  Value no is not boolean (true or false).

Needs to be =false, didn't you test this?

> Tools/gtk/jhbuild.modules:290
> +  <meson id="at-spi2-core" mesonargs="-Dintrospection=no">

Ditto