[webkit-reviews] review requested: [Bug 196312] WebKit uses wrong baseline for empty inline-flex containers, when doing `vertical-align:baseline` alignment : [Attachment 367304] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has asked  for review:
Bug 196312: WebKit uses wrong baseline for empty inline-flex containers, when
doing `vertical-align:baseline` alignment
https://bugs.webkit.org/show_bug.cgi?id=196312

Attachment 367304: Patch

https://bugs.webkit.org/attachment.cgi?id=367304&action=review




--- Comment #28 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 367304
  --> https://bugs.webkit.org/attachment.cgi?id=367304
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367304&action=review

> Source/WebCore/rendering/RenderButton.h:64
> +    int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode,
LinePositionMode = PositionOnContainingLine) const override;

Javi could you please take a new look?

I needed to do this in order to keep baseline behavior for RenderButton.
The fact that a <button> is a flexbox is an implementation detail, but the
special conditions of flexbox baseline shouldn't apply to buttons.
Actually in Blink this is also overridden, but that was there before the patch
I'm porting, that's why I didn't realized before.