[webkit-reviews] review granted: [Bug 196845] WebKit should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF : [Attachment 367274] Patch (fails to link Tools on WinCairo)

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 196845: WebKit should build successfully even with
-DENABLE_UNIFIED_BUILDS=OFF
https://bugs.webkit.org/show_bug.cgi?id=196845

Attachment 367274: Patch (fails to link Tools on WinCairo)

https://bugs.webkit.org/attachment.cgi?id=367274&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 367274
  --> https://bugs.webkit.org/attachment.cgi?id=367274
Patch (fails to link Tools on WinCairo)

View in context: https://bugs.webkit.org/attachment.cgi?id=367274&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:325
> -inline void
CanvasRenderingContext2DBase::FontProxy::initialize(FontSelector& fontSelector,
const RenderStyle& newStyle)
> +void CanvasRenderingContext2DBase::FontProxy::initialize(FontSelector&
fontSelector, const RenderStyle& newStyle)

Why are you removing inline keywords here? That seems unrelated.

> Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.h:29
> +#include <wtf/Forward.h>

Why do we need Forward.h?