[webkit-reviews] review granted: [Bug 196836] Improve the Inline Cache Stats code : [Attachment 367264] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 196836: Improve the Inline Cache Stats code
https://bugs.webkit.org/show_bug.cgi?id=196836

Attachment 367264: Patch

https://bugs.webkit.org/attachment.cgi?id=367264&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 367264
  --> https://bugs.webkit.org/attachment.cgi?id=367264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367264&action=review

> Source/JavaScriptCore/ChangeLog:43
> +2019-04-11  Michael Saboff  <msaboff at apple.com>
> +
> +	   Need a short description (OOPS!).
> +	   Need the bug URL (OOPS!).
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * jit/ICStats.cpp:
> +	   (JSC::ICEvent::operator< const):
> +	   (JSC::ICEvent::dump const):
> +	   * jit/ICStats.h:
> +	   (JSC::ICEvent::ICEvent):
> +	   (JSC::ICEvent::hash const):
> +	   * jit/JITOperations.cpp:
> +	   * jit/Repatch.cpp:
> +	   (JSC::tryCacheGetByID):
> +	   (JSC::tryCachePutByID):
> +	   (JSC::tryCacheInByID):

style: duplicate entries. remove this

> Tools/ChangeLog:34
> +2019-04-11  Michael Saboff  <msaboff at apple.com>
> +
> +	   Need a short description (OOPS!).
> +	   Need the bug URL (OOPS!).
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Scripts/ic-stats.py: Added.
> +	   (ICStats):
> +	   (ICStats.__init__):
> +	   (ICStats.parse):
> +	   (ICStats.dumpStats):
> +	   (usage):

ditto: remove

> Tools/Scripts/ic-stats.py:104
> +    print "Usage: {0} [ic-stats-file]".format(sys.argv[0])

can you also make this print with --help?
Also, can you add information in this to how to generate ic-stats-file?