[webkit-reviews] review granted: [Bug 196832] Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot : [Attachment 367249] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 15:27:32 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 196832: Web Inspector: REGRESSION(r244195): Timelines: unable to take heap
snapshot
https://bugs.webkit.org/show_bug.cgi?id=196832

Attachment 367249: Patch

https://bugs.webkit.org/attachment.cgi?id=367249&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 367249
  --> https://bugs.webkit.org/attachment.cgi?id=367249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367249&action=review

> Source/WebInspectorUI/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * UserInterface/Controllers/TimelineManager.js:

Word here please like "This regressed when I discombobulated the rotary
encabulator".


More information about the webkit-reviews mailing list