[webkit-reviews] review granted: [Bug 196822] Extract UTI mapping and allow for additions : [Attachment 367247] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 15:20:00 PDT 2019

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 196822: Extract UTI mapping and allow for additions

Attachment 367247: Patch


--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 367247
  --> https://bugs.webkit.org/attachment.cgi?id=367247

View in context: https://bugs.webkit.org/attachment.cgi?id=367247&action=review

> Source/WebCore/platform/network/mac/UTIUtilities.mm:89
> +    static const auto map = makeNeverDestroyed([] {

Why not just go straight to UTI instead of using CoreServices, if you're
already hardcoding?

More information about the webkit-reviews mailing list