[webkit-reviews] review requested: [Bug 196831] Always set _allowsSensitiveLogging to NO : [Attachment 367243] patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has asked  for review:
Bug 196831: Always set _allowsSensitiveLogging to NO
https://bugs.webkit.org/show_bug.cgi?id=196831

Attachment 367243: patch

https://bugs.webkit.org/attachment.cgi?id=367243&action=review




--- Comment #1 from Saam Barati <sbarati at apple.com> ---
Created attachment 367243

  --> https://bugs.webkit.org/attachment.cgi?id=367243&action=review

patch

Hopefully it builds. I still need to test it.

Based on the documentation in:
https://developer.apple.com/documentation/foundation/nsurlsessionconfiguration/
1411560-defaultsessionconfiguration?language=objc

"Modifying the returned session configuration object does not affect any
configuration objects returned by future calls to this method, and does not
change the default behavior for existing sessions. It is therefore always safe
to use the returned object as a starting point for additional customization."

I think this patch is safe to do without affecting other users of
"defaultSessionConfiguration".