[webkit-reviews] review granted: [Bug 196680] Add @page margin support : [Attachment 367238] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 11 13:55:08 PDT 2019
Tim Horton <thorton at apple.com> has granted zalan <zalan at apple.com>'s request
for review:
Bug 196680: Add @page margin support
https://bugs.webkit.org/show_bug.cgi?id=196680
Attachment 367238: Patch
https://bugs.webkit.org/attachment.cgi?id=367238&action=review
--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 367238
--> https://bugs.webkit.org/attachment.cgi?id=367238
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=367238&action=review
> Source/WebKit/Shared/PrintInfo.h:60
> + // These values are in 'point' unit (and not css pixel).
CSS
> Source/WebKit/Shared/WebPreferences.yaml:1639
> + webcoreBinding: RuntimeEnabledFeatures
Why is this not just a Setting!
> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:2131
> +
> +void WKPreferencesSetPageAtRuleSupportEnabled(WKPreferencesRef
preferencesRef, bool flag)
> +{
> + toImpl(preferencesRef)->setPageAtRuleSupportEnabled(flag);
> +}
> +
> +bool WKPreferencesGetPageAtRuleSupportEnabled(WKPreferencesRef
preferencesRef)
> +{
> + return toImpl(preferencesRef)->pageAtRuleSupportEnabled();
> +}
No need for new C API
> Source/WebKit/UIProcess/mac/WKPrintingView.mm:329
> + [printInfo setBottomMargin: computedPageMargin.bottom()];
No spaces after colons!
> Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:271
> +#define WebKitPageAtRuleSupportEnabledPreferenceKey
@"WebKitPageAtRuleSupportEnabled"
No need for WebKitLegacy API
More information about the webkit-reviews
mailing list