[webkit-reviews] review granted: [Bug 196793] [Web GPU] Prevent lossy 64-bit to 32-bit narrowing conversions during Metal function calls on 32-bit platforms : [Attachment 367181] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 11 09:19:58 PDT 2019
Darin Adler <darin at apple.com> has granted review:
Bug 196793: [Web GPU] Prevent lossy 64-bit to 32-bit narrowing conversions
during Metal function calls on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=196793
Attachment 367181: Patch
https://bugs.webkit.org/attachment.cgi?id=367181&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 367181
--> https://bugs.webkit.org/attachment.cgi?id=367181
Patch
I guess instead I should say review+, but please change to use isInBounds
instead of BoundsChecker. Please consider my other comments as well.
More information about the webkit-reviews
mailing list