[webkit-reviews] review granted: [Bug 196755] Add SPI WKNavigationResponse._downloadAttribute : [Attachment 367148] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 196755: Add SPI WKNavigationResponse._downloadAttribute
https://bugs.webkit.org/show_bug.cgi?id=196755

Attachment 367148: Patch

https://bugs.webkit.org/attachment.cgi?id=367148&action=review




--- Comment #6 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 367148
  --> https://bugs.webkit.org/attachment.cgi?id=367148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367148&action=review

> Source/WebKit/UIProcess/API/APINavigationResponse.h:42
> +    static Ref<NavigationResponse> create(API::FrameInfo& frame, const
WebCore::ResourceRequest& request, const WebCore::ResourceResponse& response,
bool canShowMIMEType, const WTF::String& downloadAttribute)
>      {
> +	   return adoptRef(*new NavigationResponse(frame, request, response,
canShowMIMEType, downloadAttribute));
>      }

Can take the opportunity to make the static create() just be a variadic
template :)