[webkit-reviews] review denied: [Bug 196777] Unable to run system Safari with trunk WebKit : [Attachment 367147] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 196777: Unable to run system Safari with trunk WebKit
https://bugs.webkit.org/show_bug.cgi?id=196777

Attachment 367147: Patch

https://bugs.webkit.org/attachment.cgi?id=367147&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367147
  --> https://bugs.webkit.org/attachment.cgi?id=367147
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367147&action=review

> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:46
> +#define
DYLD_MACOS_VERSION_FIRST_WITH_EXCEPTIONS_FOR_RELATED_WEBVIEWS_USING_DIFFERENT_D
ATA_STORES 0

I don't think this will fix our open source friends' problem.  We need to
define the last version and use DYLD_MACOSX_VERSION_10_14

> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:86
> +enum class AssumeSafariIsAlwaysLinkedOnAfter { No, Yes };

: bool