[webkit-reviews] review denied: [Bug 196773] Add a DiagnosticLogging method taking an arbitrary dictionary of values. : [Attachment 367143] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 196773: Add a DiagnosticLogging method taking an arbitrary dictionary of
values.
https://bugs.webkit.org/show_bug.cgi?id=196773

Attachment 367143: Patch

https://bugs.webkit.org/attachment.cgi?id=367143&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 367143
  --> https://bugs.webkit.org/attachment.cgi?id=367143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367143&action=review

Let's add HashTraits<Variant<Types...>> and some WTF tests for this.

> Source/WTF/wtf/HashFunctions.h:222
> +	       return std::hash<Variant<Types...>>(a) ==
std::hash<Variant<Types...>>(b);

This should just use operator== without using std::hash.