[webkit-reviews] review granted: [Bug 196759] OfflineAudioDestinationNode::startRendering leaks OfflineAudioDestinationNode if offlineRender exists early : [Attachment 367098] Fixes the bug

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 196759: OfflineAudioDestinationNode::startRendering leaks
OfflineAudioDestinationNode if offlineRender exists early
https://bugs.webkit.org/show_bug.cgi?id=196759

Attachment 367098: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=367098&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 367098
  --> https://bugs.webkit.org/attachment.cgi?id=367098
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=367098&action=review

> Source/WebCore/ChangeLog:9
> +	   But offlineRender can early exit without ever calling deref() in the
main thread, leaking to the leak of

s/leaking/leading/

> Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.h:69
> +    bool startRenderingIfPossible();

Nit: looks like this isn't necessary.