[webkit-reviews] review granted: [Bug 196750] Add runJavaScriptInFrame for WebPageProxy/WebPage : [Attachment 367082] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 196750: Add runJavaScriptInFrame for WebPageProxy/WebPage
https://bugs.webkit.org/show_bug.cgi?id=196750

Attachment 367082: Patch

https://bugs.webkit.org/attachment.cgi?id=367082&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 367082
  --> https://bugs.webkit.org/attachment.cgi?id=367082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367082&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:3570
>     
m_process->send(Messages::WebPage::RunJavaScriptInMainFrameScriptWorld(script,
forceUserGesture, worldName, callbackID), m_pageID);

It seems there is not much difference of processing in WebProcess between the
different runJavaScript messages.
We could call runJavaScriptInFrame here and have just one IPC message for all
cases.