[webkit-reviews] review granted: [Bug 196467] Delay initialization of quota users until the first quota request : [Attachment 366971] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 196467: Delay initialization of quota users until the first quota request
https://bugs.webkit.org/show_bug.cgi?id=196467

Attachment 366971: Patch

https://bugs.webkit.org/attachment.cgi?id=366971&action=review




--- Comment #20 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 366971
  --> https://bugs.webkit.org/attachment.cgi?id=366971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366971&action=review

> Source/WebCore/storage/StorageQuotaManager.cpp:68
> +    for (auto* user : usersToInitialize) {

What guarantees that StorageQuotaUser objects are still alive as you iterate?
You thought it was worth copying them into a new vector but you keep raw
pointers to them.