[webkit-reviews] review granted: [Bug 146718] [GTK] Layout test accessibility/aria-hidden-false-works-in-subtrees.html fails after r184890 : [Attachment 367115] Patch

[bugzilla-daemon at webkit.org]

Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> has granted Carlos Garcia
Campos <cgarcia at igalia.com>'s request for review:
Bug 146718: [GTK] Layout test
accessibility/aria-hidden-false-works-in-subtrees.html fails after r184890
https://bugs.webkit.org/show_bug.cgi?id=146718

Attachment 367115: Patch

https://bugs.webkit.org/attachment.cgi?id=367115&action=review




--- Comment #4 from Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> ---
Comment on attachment 367115
  --> https://bugs.webkit.org/attachment.cgi?id=367115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367115&action=review

> Source/WebCore/accessibility/atk/WebKitAccessible.cpp:1185
> +	   || role == AccessibilityRole::ApplicationGroup;

Fine. BUT this reminds me that we really should be implementing AtkText on most
things with text (i.e. I'd think pretty much anything which is not a non-text
widget). Not this bug, of course....