[webkit-reviews] review granted: [Bug 196762] WebCore should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF : [Attachment 367108] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 196762: WebCore should build successfully even with
-DENABLE_UNIFIED_BUILDS=OFF
https://bugs.webkit.org/show_bug.cgi?id=196762

Attachment 367108: Patch

https://bugs.webkit.org/attachment.cgi?id=367108&action=review




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 367108
  --> https://bugs.webkit.org/attachment.cgi?id=367108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367108&action=review

r=me provided the following comments are addressed.

> Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:31
> +    JSCanvasRenderingContext2D* jsCanvasRenderingContext =
JSC::jsCast<JSCanvasRenderingContext2D*>(handle.slot()->asCell());
> +    void* root = jsCanvasRenderingContext->wrapped().canvas().opaqueRoot();

We don't wanna directly call Node::opaqueRoot like this.
Just include JSNode.h instead.

> Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:37
> -    visitor.addOpaqueRoot(root(wrapped().canvas()));
> +    visitor.addOpaqueRoot(wrapped().canvas().opaqueRoot());

Ditto.