[webkit-reviews] review granted: [Bug 196746] We should clear m_needsOverflowCheck when hitting an exception in defineProperties in ObjectConstructor.cpp : [Attachment 367074] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 196746: We should clear m_needsOverflowCheck when hitting an exception in
defineProperties in ObjectConstructor.cpp
https://bugs.webkit.org/show_bug.cgi?id=196746

Attachment 367074: Patch

https://bugs.webkit.org/attachment.cgi?id=367074&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 367074
  --> https://bugs.webkit.org/attachment.cgi?id=367074
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367074&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:620
> +	   RETURN_IF_EXCEPTION_CLEARING_OVERFLOW(jsNull());

We can use `{ }` instead of `jsNull()`.