[webkit-reviews] review granted: [Bug 195000] Add support for incremental bytecode cache updates : [Attachment 366923] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 9 14:24:50 PDT 2019
Filip Pizlo <fpizlo at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 195000: Add support for incremental bytecode cache updates
https://bugs.webkit.org/show_bug.cgi?id=195000
Attachment 366923: Patch
https://bugs.webkit.org/attachment.cgi?id=366923&action=review
--- Comment #32 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 366923
--> https://bugs.webkit.org/attachment.cgi?id=366923
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=366923&action=review
r=me but it seems like this needs to be rebased and please try to put classes
in separate files.
> Source/JavaScriptCore/runtime/CachedBytecode.h:42
> +class CachePayload {
Ideally this would be a separate header. And the implementation in a separate
.cpp file.
> Source/JavaScriptCore/runtime/CachedBytecode.h:72
> +class LeafExecutable {
Ditto.
More information about the webkit-reviews
mailing list