[webkit-reviews] review granted: [Bug 196706] [CMake] WTF derived sources should only be referenced inside WTF : [Attachment 367053] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 9 12:03:25 PDT 2019


Konstantin Tokarev <annulen at yandex.ru> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 196706: [CMake] WTF derived sources should only be referenced inside WTF
https://bugs.webkit.org/show_bug.cgi?id=196706

Attachment 367053: Patch

https://bugs.webkit.org/attachment.cgi?id=367053&action=review




--- Comment #9 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 367053
  --> https://bugs.webkit.org/attachment.cgi?id=367053
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367053&action=review

>> Source/WTF/wtf/PlatformJSCOnly.cmake:-79
>> -	list(APPEND WTF_INCLUDE_DIRECTORIES
> 
> What happened to contents of WTF_INCLUDE_DIRECTORIES? How are those files
included now?

I see, it went to WTF_PRIVATE_INCLUDE_DIRECTORIES


More information about the webkit-reviews mailing list