[webkit-reviews] review denied: [Bug 196727] [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work. : [Attachment 367033] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 196727: [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't
work.
https://bugs.webkit.org/show_bug.cgi?id=196727

Attachment 367033: Patch

https://bugs.webkit.org/attachment.cgi?id=367033&action=review




--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 367033
  --> https://bugs.webkit.org/attachment.cgi?id=367033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367033&action=review

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113
> +    auto pageGroup =
WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get());

WebKitBrowserWindow is used only for WinCairo at the memoment, but also for
AppleWin in the future (hopefully). Should be renamed.
Nit: pageGroup is leaked.
auto pageGroup = adoptWK(...);
And conf, prefs and context are also leaked.