[webkit-reviews] review granted: [Bug 196719] [Web GPU] GPURenderPassEncoder updates: setBlendColor, setViewport, setScissorRect : [Attachment 367009] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 8 20:27:17 PDT 2019
Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 196719: [Web GPU] GPURenderPassEncoder updates: setBlendColor, setViewport,
setScissorRect
https://bugs.webkit.org/show_bug.cgi?id=196719
Attachment 367009: Patch
https://bugs.webkit.org/attachment.cgi?id=367009&action=review
--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 367009
--> https://bugs.webkit.org/attachment.cgi?id=367009
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=367009&action=review
> LayoutTests/webgpu/blend-triangle-strip.html:-57
> - dstFactor: "one",
Why modify this test? Why didn’t this modification cause a required change in
the expected results? Instead of modifying this test, we should make a new
test.
More information about the webkit-reviews
mailing list