[webkit-reviews] review granted: [Bug 196602] [ATK] Cleanup WebKitAccessibleHyperlink : [Attachment 366926] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 196602: [ATK] Cleanup WebKitAccessibleHyperlink
https://bugs.webkit.org/show_bug.cgi?id=196602

Attachment 366926: Patch

https://bugs.webkit.org/attachment.cgi?id=366926&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 366926
  --> https://bugs.webkit.org/attachment.cgi?id=366926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366926&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp:-418
> -    static volatile gsize typeVolatile = 0;
> -
> -    if (g_once_init_enter(&typeVolatile)) {
> -	   static const GTypeInfo tinfo = {
> -	       sizeof(WebKitAccessibleHyperlinkClass),
> -	       (GBaseInitFunc) 0,
> -	       (GBaseFinalizeFunc) 0,
> -	       (GClassInitFunc)(GCallback) webkitAccessibleHyperlinkClassInit,
> -	       (GClassFinalizeFunc) 0,
> -	       0, /* class data */
> -	       sizeof(WebKitAccessibleHyperlink), /* instance size */
> -	       0, /* nb preallocs */
> -	       (GInstanceInitFunc)(GCallback) webkitAccessibleHyperlinkInit,
> -	       0 /* value table */
> -	   };
> -
> -	   static const GInterfaceInfo actionInfo = {
> -	       (GInterfaceInitFunc)(GCallback)atkActionInterfaceInit,
> -	       (GInterfaceFinalizeFunc) 0, 0
> -	   };
> -
> -	   GType type = g_type_register_static(ATK_TYPE_HYPERLINK,
"WebKitAccessibleHyperlink", &tinfo, GTypeFlags(0));
> -	   g_type_add_interface_static(type, ATK_TYPE_ACTION, &actionInfo);
> -
> -	   g_once_init_leave(&typeVolatile, type);
> -    }

Heh, this is *really* old school!