[webkit-reviews] review granted: [Bug 196655] [CMake][WinCairo] Separate copied headers into different directories : [Attachment 366843] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 196655: [CMake][WinCairo] Separate copied headers into different
directories
https://bugs.webkit.org/show_bug.cgi?id=196655

Attachment 366843: Patch

https://bugs.webkit.org/attachment.cgi?id=366843&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 366843
  --> https://bugs.webkit.org/attachment.cgi?id=366843
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366843&action=review

I'm OK with this, but I'm a little reluctant that none of our CMake experts
have reviewed it yet. Please wait one day before landing to give time for
others to comment.

> Source/WebCore/CMakeLists.txt:20
> +    "${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS_DIR}"

Well this is confusing. What is the difference between JSC public and private
framework headers, and why is the private include dir accessible outside JSC?