[webkit-reviews] review granted: [Bug 196621] Add a test to check for the service worker process name : [Attachment 366747] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 8 13:09:56 PDT 2019
Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 196621: Add a test to check for the service worker process name
https://bugs.webkit.org/show_bug.cgi?id=196621
Attachment 366747: Patch
https://bugs.webkit.org/attachment.cgi?id=366747&action=review
--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 366747
--> https://bugs.webkit.org/attachment.cgi?id=366747
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=366747&action=review
> Source/WebCore/testing/ServiceWorkerInternals.mm:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.
2019
> Source/WebCore/testing/ServiceWorkerInternals.mm:40
> + return "name: " + name;
Why prepend "name: " ? I think the test would look much better without.
More information about the webkit-reviews
mailing list