[webkit-reviews] review granted: [Bug 196608] Update touch-action region on property changes : [Attachment 366934] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 8 13:01:50 PDT 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 196608: Update touch-action region on property changes
https://bugs.webkit.org/show_bug.cgi?id=196608
Attachment 366934: patch
https://bugs.webkit.org/attachment.cgi?id=366934&action=review
--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366934
--> https://bugs.webkit.org/attachment.cgi?id=366934
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=366934&action=review
> Source/WebCore/rendering/RenderLayerBacking.cpp:2489
> + m_owningLayer.invalidateEventRegion();
It's a shame to trigger expensive event region building for non-layout changes
like color changes. Can we use a StyleDiff somewhere instead? Imagine an
animation of background-color triggering region rebuilds every frame :(
More information about the webkit-reviews
mailing list