[webkit-reviews] review granted: [Bug 196552] Make HSTS list handling more robust against unexpected content : [Attachment 366955] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 8 12:54:40 PDT 2019


Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 196552: Make HSTS list handling more robust against unexpected content
https://bugs.webkit.org/show_bug.cgi?id=196552

Attachment 366955: Patch

https://bugs.webkit.org/attachment.cgi?id=366955&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 366955
  --> https://bugs.webkit.org/attachment.cgi?id=366955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366955&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:163
> +    auto hostnames = static_cast<HashSet<String>*>(context);

We usually prefer auto* for raw pointers.


More information about the webkit-reviews mailing list