[webkit-reviews] review requested: [Bug 176810] for..in on a Proxy loops over non enumerable properties : [Attachment 366956] Reland [JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 8 11:35:03 PDT 2019


Caitlin Potter (:caitp) <caitp at igalia.com> has asked  for review:
Bug 176810: for..in on a Proxy loops over non enumerable properties
https://bugs.webkit.org/show_bug.cgi?id=176810

Attachment 366956: Reland [JSC] Filter DontEnum properties in
ProxyObject::getOwnPropertyNames()

https://bugs.webkit.org/attachment.cgi?id=366956&action=review




--- Comment #82 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Created attachment 366956

  --> https://bugs.webkit.org/attachment.cgi?id=366956&action=review

Reland [JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()

There was some redundant DontEnum filtering code in ObjectConstructor.cpp's
ownPropertyKeys() function, which I've removed (and verified that it compiles
and passes test262). It may still be slightly broken, I'll see shortly.


More information about the webkit-reviews mailing list