[webkit-reviews] review granted: [Bug 196315] All prototypes should call didBecomePrototype() : [Attachment 366853] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 196315: All prototypes should call didBecomePrototype()
https://bugs.webkit.org/show_bug.cgi?id=196315

Attachment 366853: Patch

https://bugs.webkit.org/attachment.cgi?id=366853&action=review




--- Comment #15 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 366853
  --> https://bugs.webkit.org/attachment.cgi?id=366853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366853&action=review

r=me

> Source/JavaScriptCore/runtime/InternalFunction.h:56
> +    {

revert

> Source/JavaScriptCore/runtime/JSGlobalObject.h:1037
> +    

revert

> Source/JavaScriptCore/runtime/JSObject.cpp:3912
> +    

revert

> Source/JavaScriptCore/runtime/Structure.cpp:214
> +    if (prototype.isCell())
> +	   RELEASE_ASSERT(prototype.getObject()->mayBePrototype());

There is more than one kind of structure constructor. Perhaps do it somewhere
where all are covered? Probably in finishCreation.

Probably also worth doing in Structure::changePrototypeTransition