[webkit-reviews] review granted: [Bug 196077] We should pass minimumEffectiveDeviceWidth to web process on new page creation. : [Attachment 366852] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 5 16:18:21 PDT 2019
Chris Dumez <cdumez at apple.com> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 196077: We should pass minimumEffectiveDeviceWidth to web process on new
page creation.
https://bugs.webkit.org/show_bug.cgi?id=196077
Attachment 366852: Patch.
https://bugs.webkit.org/attachment.cgi?id=366852&action=review
--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 366852
--> https://bugs.webkit.org/attachment.cgi?id=366852
Patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=366852&action=review
r=me
> LayoutTests/ChangeLog:10
> + Reviewed by NOBODY (OOPS!).
This goes before "Add a layout test..."
> Source/WebCore/page/ViewportConfiguration.cpp:180
> + updateMinimumLayoutSize();
Could this be moved inside updateDefaultConfiguration() if it is needed
whenever we update the default config?
> Source/WebKit/ChangeLog:12
> + Reviewed by NOBODY (OOPS!).
Should come before the description.
> Source/WebKit/Shared/WebPageCreationParameters.h:151
> + double viewportConfigurationMinimumEffectiveDeviceWidth;
Should really have a default value, to be safe.
> Tools/ChangeLog:12
> + https://bugs.webkit.org/show_bug.cgi?id=196077
What's this?
> Tools/ChangeLog:13
> + <rdar://problem/49108202>
What's this?
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:5923
> + EXPECT_EQ([width intValue], 1024);
1024 should go first.
More information about the webkit-reviews
mailing list