[webkit-reviews] review granted: [Bug 196659] [Cocoa] Awaken UIProcess in WebContent process is awakened from suspensions unexpectedly. : [Attachment 366849] WIP

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted  review:
Bug 196659: [Cocoa] Awaken UIProcess in WebContent process is awakened from
suspensions unexpectedly.
https://bugs.webkit.org/show_bug.cgi?id=196659

Attachment 366849: WIP

https://bugs.webkit.org/attachment.cgi?id=366849&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 366849
  --> https://bugs.webkit.org/attachment.cgi?id=366849
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=366849&action=review

> Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.h:40
> +    ProcessTaskStateObserver(Client&);

explicit?

> Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:44
> +static const Seconds UnexpectedActivityDuration = 10_s;

I think our statics usually start with a lowercase letter.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:306
> +	   uiProcessAssertion->setState(AssertionState::Suspended);

Do we really need to do this? Why doesn't destroying the ProcessAssertion
suffice?