[webkit-reviews] review granted: [Bug 190918] REGRESSION(AppleWebKit/605.1.15): WebDownloadDelegate delegate methods called on non-main thread : [Attachment 366836] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 190918: REGRESSION(AppleWebKit/605.1.15): WebDownloadDelegate delegate
methods called on non-main thread
https://bugs.webkit.org/show_bug.cgi?id=190918

Attachment 366836: Patch

https://bugs.webkit.org/attachment.cgi?id=366836&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 366836
  --> https://bugs.webkit.org/attachment.cgi?id=366836
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366836&action=review

> Source/WebKitLegacy/mac/Misc/WebDownload.mm:85
> +    callOnMainThread([realDelegate = retainPtr(realDelegate), download =
retainPtr(download)] {

Why the mix of callOnMainThread and dispatch_sync(dispatch_get_main_queue())?