[webkit-reviews] review denied: [Bug 128750] AX: Move the ~400 lines #defines in WebAccessibilityObjectWrapperMac.mm to a separate file. : [Attachment 366826] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 5 11:52:34 PDT 2019


Darin Adler <darin at apple.com> has denied yevseytsev <yevseytsev at gmail.com>'s
request for review:
Bug 128750: AX: Move the ~400 lines #defines in
WebAccessibilityObjectWrapperMac.mm to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=128750

Attachment 366826: Patch

https://bugs.webkit.org/attachment.cgi?id=366826&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 366826
  --> https://bugs.webkit.org/attachment.cgi?id=366826
Patch

This patch has a lot of unrelated changes. Please submit another without them.

Also, please give a rationale for why moving these lines is a good idea. The
title of a bug typically needs to answer the question "why?" as well as just
saying what’s changing.


More information about the webkit-reviews mailing list