[webkit-reviews] review granted: [Bug 196562] Changing default website policies shouldn't change default website policies in subsequent navigations : [Attachment 366695] Really fix the WPE build?

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 196562: Changing default website policies shouldn't change default website
policies in subsequent navigations
https://bugs.webkit.org/show_bug.cgi?id=196562

Attachment 366695: Really fix the WPE build?

https://bugs.webkit.org/attachment.cgi?id=366695&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 366695
  --> https://bugs.webkit.org/attachment.cgi?id=366695
Really fix the WPE build?

View in context: https://bugs.webkit.org/attachment.cgi?id=366695&action=review

> Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:65
> +	   WTF::String name = field.name();
> +	   WTF::String value = field.value();
> +	   if (auto newHeaderField =
WebCore::HTTPHeaderField::create(WTFMove(name), WTFMove(value)))
> +	       customHeaderFields.append(WTFMove(*newHeaderField));

Shouldn't this use HTTPHeaderField copy constructor